Skip to content

[PoC] Route to correct MW version#987

Closed
outdooracorn wants to merge 1 commit into
mainfrom
mw-backend-version-lookup
Closed

[PoC] Route to correct MW version#987
outdooracorn wants to merge 1 commit into
mainfrom
mw-backend-version-lookup

Conversation

@outdooracorn

@outdooracorn outdooracorn commented Oct 29, 2025

Copy link
Copy Markdown
Member

Bug: T407504

@outdooracorn outdooracorn force-pushed the mw-backend-version-lookup branch from 680a0c4 to df69f2e Compare October 29, 2025 15:43
@deer-wmde

deer-wmde commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

The MediaWikiHostResolver class looks great to me so far!

A note about the WikiEntityImportJob: unfortunately this job is not as trivial to test as just firing it off via php artisan job:dispatch or something, as it is meant to be used in combination with https://github.com/wbstack/transferbot (see https://phabricator.wikimedia.org/T352421)

I tried to run it like this:

docker run -e TARGET_WIKI_OAUTH_CONSUMER_TOKEN="x" -e TARGET_WIKI_OAUTH_CONSUMER_SECRET="x" -e TARGET_WIKI_OAUTH_ACCESS_TOKEN="x" -e TARGET_WIKI_OAUTH_ACCESS_SECRET="x" --rm ghcr.io/wbstack/transferbot:main https://test-new-143.wbaas.dev/ https://test-139.wbaas.dev/ Q1

But at some point it errors for me with urllib.error.URLError: <urlopen error [Errno 111] Connection refused> - And I'm not sure if it's something that I did wrong or if that tool even still works, so I'd suggest to not get hang up with this one in case you also run into issues here

deer-wmde
deer-wmde reviewed Nov 4, 2025
View reviewed changes
Comment thread app/Services/MediaWikiHostResolver.php
@@ -0,0 +1,37 @@
<?php

namespace App\Services;

@deer-wmde deer-wmde Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unclear about the introduction of this Service namespace and location, this could be confused with the Laravel concept of Service Providers https://laravel.com/docs/10.x/providers

I think App\Helper would be more appropriate https://github.com/wbstack/api/tree/main/app/Helper

I got confused, Service Container is the pattern used here https://laravel.com/docs/10.x/container

@deer-wmde deer-wmde mentioned this pull request Nov 4, 2025
Merged
@tarrow tarrow mentioned this pull request Nov 5, 2025
Merged
@outdooracorn

outdooracorn commented Nov 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Closing this as superseded by #989 and #988

@outdooracorn outdooracorn deleted the mw-backend-version-lookup branch November 11, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deer-wmde deer-wmde deer-wmde left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@outdooracorn @deer-wmde